Conversation
piaskowyk
reviewed
Jul 1, 2024
packages/react-native-reanimated/src/layoutReanimation/web/componentUtils.ts
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/layoutReanimation/web/componentUtils.ts
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/layoutReanimation/web/componentUtils.ts
Outdated
Show resolved
Hide resolved
This was referenced Jul 25, 2024
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary Currently some of our animations flicker on google chrome browser. This PR moves setting animation into `requestAnimationFrame` callback - this way we will be sure that animation will be properly set before next repaint. ## Comparison ### Before https://github.com/software-mansion/react-native-reanimated/assets/63123542/fe674d23-d1bb-44c3-a870-335c330c7073 ### After https://github.com/software-mansion/react-native-reanimated/assets/63123542/2a4833a7-c3d9-4a59-b108-a7f4cc166f1f ## Test plan Tested on default animations example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently some of our animations flicker on google chrome browser. This PR moves setting animation into
requestAnimationFramecallback - this way we will be sure that animation will be properly set before next repaint.Comparison
Before
Nagranie.z.ekranu.2024-06-26.o.13.54.18.mov
After
Nagranie.z.ekranu.2024-06-26.o.13.53.06.mov
Test plan
Tested on default animations example